Intro component with sign-up form | newbie edition

Community feedback

• 

  Samuel Palacios•615

  @samuelpalaciosdevPosted over 3 years ago

  Hi, Luis👋

  Great job on this challenge. Your solution looks good and it scales pretty well👍

  I only suggest some things 😉:

  -Changing the buttons to an <a> (anchor link). If this would be an actual webpage, those buttons should redirect somewhere.

  -Creating a focus state on the input. So when someone clicks on them, the border changes of color or something fancy.

  -Creating a specific div for the images on the inputs. I don't know, setting those as background-images, doesn't look like the best practice.

  I hope you have a nice day, keep coding!💙

  1

  ---

  

  Luis Colina•1,043

  @Comet466Posted over 3 years ago

  @samuelpalaciosdev hi samuel, thanks for taking a look at my solution can you believe that i totally forgot of the hover states? my god man, can you explain yourself a about what do you mean by " Creating a specific div for the images on the inputs"

  0

  

  Samuel Palacios•615

  @samuelpalaciosdevPosted over 3 years ago

  Hi Luis, first of all you should also look those accessibility and html issues. Whenever you make a website, as an advise use W3C Markup Validation Service

  0

  

  Samuel Palacios•615

  @samuelpalaciosdevPosted over 3 years ago

  About your question, I mean, those "icons" that are at the right side of the inputs, you could put each one in a div, above its corresponding input div and set the input position to relative and set the icons position to absolute. With that you can manage the properties, top, right, bottom and left, that will allow you to position the icons without having to put them as background-image.

  1

  

  Luis Colina•1,043

  @Comet466Posted over 3 years ago

  @samuelpalaciosdev yeah thats a better solution that the one i came up with, thanks for that samuel really appreciate

  0

  

  Samuel Palacios•615

  @samuelpalaciosdevPosted over 3 years ago

  I'm glad I helped you. Have a nice day, keep coding

  0
• 

  shahab shafie•70

  @Shhb-Coder-1999Posted over 3 years ago

  its better to change your inputs border color when click on them :) good job
  👍

  1

  ---

  

  Luis Colina•1,043

  @Comet466Posted over 3 years ago

  @shahabs789 yeah you're right, change the red color of the input on click, i will work on it, thanks

  1