Submitted over 2 years ago

Intro component with signup form master

Keagan Dickinson•160

@PhisherFTW

Preview site View code

This is a solution for...Intro component with sign-up form

HTML
CSS
JS

1newbie

Design comparison

SolutionDesign

Solution retrospective

This challenge was great, it forced me to use alot of the skills I am currently learning like Javascript DOM and more, I am very happy with how it turned out, although there is one small issue

When I change the width of it to be below 368, the terms and services messages messes up and I know its because I used span in order to target the specific text so I could turn it red, but if you have a different way please let me know.

Thanks

Community feedback

Stefani Josifovska•270
@stefani-josifovskaPosted over 2 years ago
Hello Keagan, first of all great job! I only have one suggestion: maybe, if all the input fields are valid on submission, you could clear the input fields out of give any other kind of feedback to the user, so that he knows what is going on. Regarding your question, the display: flex on the "termsservices" class causes this problem, because it sees the text and the span as two elements and thus applies properties you don't really want. So maybe delete that property, and add a text-align: center instead, and your problem will be gone. :) Happy coding!
Marked as helpful
1
Keagan Dickinson•160
@PhisherFTWPosted over 2 years ago
@stefani-josifovska Fantastic response, thank you so much for your feedback, I will implement your suggestions asap.
0

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord