Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Intro Component With Signup Form Master

SaakarX 320

@saakarx

Desktop design screenshot for the Intro component with sign-up form coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

T
Grace 29,310

@grace-snow

Posted

Hi

I have a few suggestions for you ☺

  • no text should be in a span/div alone. You need a h1
  • introduce desktop styles a little later. They're kicking in on mobile landscape on my small phone and each half of content looks very narrow
  • all form inputs need a name attribute and an aria-label
  • the error icons should be background images really, not in the html. If you really want them to be in the html their alt attribute needs to be empty and they need aria-hidden="true"
  • do you have hover and focus states in this? Focus states on form inputs in particular are important
  • use email input type for email, not text
  • add autocomplete attributes

Hope this will help you

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord