Intro Component With Signup Form Master

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  Hi

  I have a few suggestions for you ☺

  • no text should be in a span/div alone. You need a h1
  • introduce desktop styles a little later. They're kicking in on mobile landscape on my small phone and each half of content looks very narrow
  • all form inputs need a name attribute and an aria-label
  • the error icons should be background images really, not in the html. If you really want them to be in the html their alt attribute needs to be empty and they need aria-hidden="true"
  • do you have hover and focus states in this? Focus states on form inputs in particular are important
  • use email input type for email, not text
  • add autocomplete attributes

  Hope this will help you

  1