Intro Component With Signup Form Master

Community feedback

• 

  Fazza Razaq Amiarso•2,340

  @fazzaamiarsoPosted over 1 year ago

  Hi Joao! Nice solution!

  I have a tip to reduce your code. You can extract some logic into a smaller function.

  function showError(elementId) {
    document.getElementsByClassName(`error-${elementId}`)[0].style.display =
      'block';
    document.getElementById(elementId).style.borderColor = 'hsl(354, 100%, 66%)';
  }
  
  function hideError(elementId) {
    document.getElementsByClassName(`error-${elementId}`)[0].style.display =
      'none';
    document.getElementById(elementId).style.borderColor = 'hsl(120, 100%, 31%)';
  }
  
  function checkFirstName() {
    const firstNameValue = firstName.value;
    if (firstNameValue === '') showError('firstName');
    else hideError('firstName');
  }
  

  I hope it answers your question! Cheers!

  Marked as helpful

  0

  ---

  

  João Vitor•420

  @jvssvjPosted over 1 year ago

  @fazzaamiarso No doubt cleared my doubts, thank you friend. I just started in JS, my code is a mess but it works (sometimes) 😆

  0