intro component with signup form

Community feedback

• 

  bikeinman•1,080

  @BikeInManPosted almost 3 years ago

  Validation regex for your password is failing for some reason. It is passing even null string(""). I think * in the regex(const passPattern = /^[a-zA-Z0-9]*$/g;) is causing the problem.

  Test your regex here and change accordingly. https://regex101.com/

  Otherwise, nice coding.

  Marked as helpful

  1

  ---

  

  Phil•185

  @PhilJGPosted almost 3 years ago

  @BikeInMan Thanks I figured out the issue. Turned out it was a small adjustment of the regex. The one I entered accepted a blank input. This is what I changed it to /[a-zA-Z0-9]/g

  0

  

  bikeinman•1,080

  @BikeInManPosted almost 3 years ago

  @PhilJG Thanks for the update. Glad you have fixed the issue.

  0
• 

  Hexer•3,660

  @EmmanuelHexerPosted almost 3 years ago

  Great job overall man. Keep it up

  • To fix your accessibility issues wrap your component with main element.

  • You must use heading tags like h1 - h6 instead of divs.

  Marked as helpful

  0

  ---

  

  Phil•185

  @PhilJGPosted almost 3 years ago

  @Phalcin Thanks I just added the <main> wrapper. Regarding the h1 - h6. Are you suggesting I change all the <p> to headers?

  0