intro component with sign-up form

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 4 years ago

  Hey Farouk. Congrats on submitting your first solution! The live preview link isn't working for your solution at the moment. If you could update it I'll be able to take a look at your project. You can update your solution by clicking the 3 vertical white dots at the top right of this page and select Edit Solution.

  Once you've updated the URL I'll take a look 👍

  1

  ---

  

  farouk•30

  @farouk-afolabiPosted over 4 years ago

  @mattstuddert thank you very much sir ,i have updated the solution ...i really appreciate it .

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 4 years ago

  @farouk-afolabi great! OK, here are my pointers after taking a look at your solution:

  • You're using the br tag quite a bit to force the line to break. I'd recommend not doing that as it can cause issues, especially when you start to make the site responsive. Instead, let the width of the parent element or the element itself dictate where the line breaks in the text.
  • I'd say the text below the h1 is a paragraph of text. This means a p tag would be more suitable than a span.
  • You've uppercase the "Claim your free trial" text in the HTML directly. ry to avoid doing that as some screen reader software will read this content letter-by-letter which makes that content inaccessible to screen reader users. Instead, write it normally in your HTML and then use text-transform: uppercase; in your CSS to visually uppercase the text to match the design.
  • Avoid using IDs as CSS selectors. They have high specificity and can't be reused on the page, so they're not good for the purpose of styling. Instead, I'd recommend sticking to class, attribute, pseudo, and type selectors. Using these will help keep your CSS more maintainable.
  • Practice good code indentation. It will help you when you're debugging your own code and make it much more readable for others.
  • I'd recommend going through the CSS one more time matching your solution up to the design to try and get your project as close to the design as possible. Accuracy is a key part of being a front-end developer, so it's a skill that's well worth taking some time to build.

  The overall structure is there, your project just needs some refining. Great work though. Keep it up and keep practicing! 🙂

  1

  

  farouk•30

  @farouk-afolabiPosted over 4 years ago

  @mattstuddert I'm so happy you reviewed my work....thank you very much sir ,i will go through the css again ,i really appreciate it .

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 4 years ago

  @farouk-afolabi you're welcome! I'm happy to help 🙂

  0