Submitted about 2 years ago
Intro component with sign-up form (HTML/CSS/JS - Responsive)
@melco10
Design comparison
SolutionDesign
Solution retrospective
What did you find difficult while building the project?
- Building responsive especially the function warn of form.
- Trial and error of building function warn and also my logic. Which areas of your code are you unsure of?
- My CSS and JS, I'm pretty sure it can be better in styling and also the function logic of Active warn state js. and also I'm struggling of figuring it out on styling code and JavaScript function code, because of my knowledge on front-end are still lacking yet.
"Feedback is welcome" "If some of the code lines are something off, feel free to correct me."
Community feedback
- @Kamasah-DicksonPosted about 2 years ago
- Your solution looks great but not responsive. Use max-width for your card instead of just width .
- Don't use px for card widths, use rem to achieve responsiveness.
- To help with the accessibility issues wrap your card in a main semantic tag.
- Your footer must be text align center.
- Bonus : Headings must be used in reducing order e.g h1,h2,h3,h4 do not mixed them up they should be used in descending order.
- Stop using px units use rem and em besides you are doing pretty good man๐
Happy coding and have a nice day๐
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord