Sign-Up Form HTML CSS JAVA SCRIPT

Community feedback

• 

  Simeon Udoh•535

  @simeon4realPosted almost 5 years ago

  Hello Vincenzo, Congratulations on your new solution on this challenge. Like you, I plan on going back to all the projects I worked on to apply my new Javascript knowledge to them. I'm still learning like you. 😁 About your submission, I noticed some things which could be improved.

  1. First, Start using relative units instead of fixed units like pixels. Plus we don't know which devices our users will access our web apps from. Also, CSS is supposed to flow like water and adapt to any screen size you throw at it. But you can't do that if you defined fixed values with Pixels.

  So I suggest you start using relative units like rem and em. Trust me, they will make your life easier as they will scale to new screen sizes..

  2. Your HTML isn't that Semantic. You used way too many divs though it doesn't matter much since this is a relatively small project but you should look it up.

  3. Move that inline style for .attribution to your styles.css file. It's considered as a best practice to avoid inline styles.

  4. You forgot to add accessibility features to your password input but you added accessibility to the email and name. A quick accessibility fix should get this done.

  Once again, congrats on your solution. The only thing that works is more work

  You can upvote my feedback if you found it useful. I'll appreciate :)

  3

  ---

  

  Vincenzo Marcovecchio•1,085

  @VincenzoMarcovecchioPosted almost 5 years ago

  @simeon4real Hello Simon your feedback is really appreciated I can see your taking the job seriously, good one on you. More work will do for me, i don't plan to be a developer anytime soon so hey no rush :). I will take your suggestions as a good lesson. I really need these ! Thank you

  0
• 

  Tek Loon•120

  @tlcheah2Posted almost 5 years ago

  Hi Vincenzo,

  Great work. The feedback I have is on the upper form div.

  It would be good as well if you can set the padding on left and right as well. This is because when I size down my browser, the text becomes very close to the button border.

  Just some minor details. I hope it helps.

  Thanks

  2

  ---

  

  Vincenzo Marcovecchio•1,085

  @VincenzoMarcovecchioPosted almost 5 years ago

  @tlcheah2 hey thanks for your answer, it's definitely an adjustment i have to make. Good one on you

  0