Design comparison
Solution retrospective
I really enjoyed doing this challenge. I am open for any feeback. Thank you for your time! Happy Coding 😌
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
LABELS 🔖:
input
elements wants alabel
associated with it
- A
<label>
is used to create a caption for a form control. The<label>
can be associated with a form control either implicitly by placing the control element inside the label element, or explicitly by using the for attribute
- Effective form
labels
are required to make forms accessible. The purpose ofform
elements such ascheckboxes
,radio
buttons,input
fields, etc, is often apparent to sighted users
- Even if the
form
element is not programmatically labeled. Screen readers users require useful formlabels
to identifyform
fields, So here usingaria-label="{values}"
attributes forinput
is enough to be accessible
- Example:
<input type="text" aria-label="First Name" placeholder="First Name" id="first-name" name="first-name">
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1@Mike-DavePosted over 1 year ago@0xAbdulKhalid Thank you so for much for your feedback, I do appreciate.
0 - @kwngptrlPosted over 1 year ago
Maybe you could put a max-width for the text on the left side. It seems a little too long as per the design when full screen.
You used Tailwind on this but didn't tag it like #tailwind. I don't know if it can still be edited.
Overall, very good effort.
Marked as helpful1@Mike-DavePosted over 1 year ago@kwngptrl Thank you so much, I have added the max-width but it doesn't seem to be showing here like the design, but it shows on my laptop and I have also added the #tailwind tag. Thank you so much for your help.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord