Design comparison
Solution retrospective
Hello all! I really enjoyed this project :) For the "success modal" I made, I made it open when it's submitted by clicking the bottom button, but I couldn't figure out how to make it open only when all fields are correctly filled... also I made two close buttons on the modal (x button on the top right and 'ok' button) but only x button works and somehow 'ok' button works like the submit button in the form and does not close the modal. If anyone could go see my code on git and give me some kind of feedback, I'd appreciate it so much!
Thanks for checking it out :) happy coding!
Community feedback
- @analuzcervantesPosted over 3 years ago
Hi Hyunji Kim! π
Good job on the challenge! π I like the validation you did β€
If I understood correctly what you want to do... You can do it with a blur event, you can answer me here if you need more information π
I would like to give you some advice:
- The width of the page is a little bigger, you need to remove the width 100vw from the body
- To solve problems for inputs name available to an accessibility API: Add aria-labelledby attribute to all the inputs (you can check this in your HTML issues report)
Keep coding! π»πΎ
3@joshuandelevaPosted over 3 years agoHi Hyunji kim can u share any site i can get the background svg image ..its amazing
0@creativehkimPosted over 3 years ago@analuzcervantes Oh I have not heard of the blur event yet..I will look into it and add it to the code! I just fixed my accessibility issue with aria-label attribute. :) Thank you so much for your advice! :)
1@creativehkimPosted over 3 years ago@joshuandeleva Hi Josua! If you were wondering about the background svg I used for the project, it is included in the project folder. (located in the "images" folder) I just changed the color. :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord