Hexer• 3,660
@Phalcin
Posted
Great job overall. You did well.
Marked as helpful
0
Submitted
Intro component with sign-up form challenge hub - HTML CSS JavaScript
Karin• 20
@KariinDeLeeuw
Design comparison
Solution retrospective
Hi. Feedback would be appreciated. I didn't use the ! image icon because the whole form would jump around and I didn't know how to fix it.
Community feedback
Karol Binkowski• 1,640
@GrzywN
Posted
Good job on your project. You can add hover state for your button to make it fancier. Have a nice day and keep it up!
Marked as helpful
0
Karin• 20
@KariinDeLeeuw
Posted
@GrzywN Something I normally do but forgotten this time. Thanks!
0
Naveen Gumaste• 10,460
@NaveenGumaste
Posted
Hay ! Karin Good Job on challenge
These below mentioned tricks will help you remove any Accessibility Issues
-> Add Main tag after body <main class="container"></main>
-> Bad value `` for attribute name on element input, why you use back-ticks?
-> Learn more on accessibility issues
If this comment helps you then pls mark it as helpful!
Have a good day and keep coding 👍!
Marked as helpful
0
Karin• 20
@KariinDeLeeuw
Posted
@Crazimonk Thank you for your feedback. I changed the div tag in a main tag. I have no idea why HTML issues is reporting back that I use back-ticks because I didn't use them. I removed for the time being the name tag in the input field because I don't use them in this setting.
Thanks for pointing me to the accessibility and html report. Totally forgot to put my code through a validator before uploading.
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord