Design comparison
Solution retrospective
I have managed to complete the design and make the form work as expected, altough i think that the script is very redundant and i'm thinking it's very possible to write it in a better way.
Any feedback is appreciated!
Community feedback
- @AdrianoEscarabotePosted almost 2 years ago
Hi tyVespA, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.
if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem! link -> px to rem
Document should have one main landmark, this problem is being caused by the fact that there is no main tag around the main content of the page! Since this challenge is based on only one component, there is no other component more important than it on this page, so to solve this, wrap all the content with the
main
tag,It's always good to pay attention to the correct use of semantic html elements, as they are extremely important for people who use screen readers, to know what the main content of the page is in the case of the
main
tag!The rest is great!
I hope it helps... 👍
0@tyVespAPosted almost 2 years ago@AdrianoEscarabote Hi Adriano thanks for your feedback! I've heard about the issues that pixel bring, i will try to use rem from now on, have a great day!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord