Intro component with sign-up form

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  Great work on this challenge! Your validation code looks good! There are so many ways that it could be done, but your solution is succinct and reusable, which is great.

  I've noticed a couple of things in your HTML:

  • You currently don't have a h1 element, which I'd always recommend having.
  • If you don't have label elements to pair up with inputs, be sure to add the aria-label attribute to each input element so that they are accessible to screen reader users.

  Hope that helps, keep up the great work! 👍

  1

  ---

  

  P

  Hamza H.•460

  @hhamza1Posted about 5 years ago

  @mattstuddert Thank you for the feedback and thanks for this great platform. Hope new challenging projects would be coming

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  @hhamza1 glad you like it! I'm working on some new challenges at the moment and will be adding more next week, so keep an eye out! 🙂

  0