Design comparison
SolutionDesign
Solution retrospective
Any advice of how i improve my code?
Community feedback
- @vanzasetiaPosted over 2 years ago
Hi, @iagohenrique2009! 👋
I'm afraid that it's actually not finished yet. It's not responsive. So, my recommendation is to try to make the site responsive.
Other feedback.
- The text content for the submit button would be the text inside it, not coming from the
value
attribute. So, I recommend removing thevalue
attribute. - Use CSS to uppercase the text. The uppercased word in the HTML might be spelled by the screen reader (spelled letter by letter).
- There should not be text in
span
anddiv
alone; instead wrap the text with a meaningful element like a paragraph element. - To make the error messages accessible by the screen reader, I would recommend do the following:
- First, have an
id
for each error message. - Second, have an
aria-describedby="<id>"
attribute for each input pointing to each error message element. - Third, have an
aria-live
attribute on each error message.
- First, have an
That's it! Hope this helps.
Marked as helpful1@iagohenrique2009Posted over 2 years ago@vanzasetia Thanks for the help friend i will modify my project soon as possible!
0@vanzasetiaPosted over 2 years ago@iagohenrique2009 No problem! Feel free to inform me once you've updated the solution! 😉
0 - The text content for the submit button would be the text inside it, not coming from the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord