Intro Component with Sign Up Form using SCSS, JS, Flexbox and Grid

Community feedback

• 

  Udochukwu Amaefule•570

  @UDsGitHubPosted almost 3 years ago

  Hi Mohamad, Nice work on your site... a few things you could add to make it work better..

  1. min-height: 100vh on your body so that the background wouldnt clip on the bottom.. also if you have background-repeat: no-repeat, remove that too.
  2. You could add padding to your body so that its children wouldnt touch the borders of the screen.
  3. You should make the purple "Try it free 7 days then $20/mo. thereafter" a link (a tag) because it is supposed to be a link.
  4. You could remove the empty form action attribute and other attribute and let them default. Other than that, you should be good my man.. keep it up👍

  Marked as helpful

  0

  ---

  

  Mohamad Adithya•290

  @mohamadadithyaPosted almost 3 years ago

  @UDsGitHub Hey, thanks for your feedback/advice, it's help me a lot ;).

  0