Intro component with sign up form using HTML, CSS and JS

Community feedback

• 

  Christian Edel•0

  @MisterEdelPosted almost 4 years ago

  Hi Shadib, it looks good. I have some suggestions to your code:

  1. Add labels to the input, you can hide them with something like bootstraps .sr-only class

  .sr-only {
    position: absolute;
    width: 1px;
    height: 1px;
    padding: 0;
    margin: -1px;
    overflow: hidden;
    clip: rect(0 0 0 0);
    border: 0;
  }
  

  2. Use a real button, instead of div role="button" you could use button type="submit"

  0

  ---

  

  Shadib Shah•610

  @shadib0797Posted almost 4 years ago

  @MisterEdel that's what i want to know why my JS validation changes does not persist when using button type="submit" or any other, they show up like for 1 sec and then disappears.

  0

  

  Christian Edel•0

  @MisterEdelPosted almost 4 years ago

  @shadib0797 you could use preventDefault on the click event to stop the submission if there are errors. See here: https://developer.mozilla.org/en-US/docs/Web/API/Event/preventDefault

  0