Skip to content
Submitted almost 3 years ago

Intro component with sign up form using BEM, Sass, JS and mobile first

Jaycee Altamia•330
@simplyJC
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Intro component with sign-up form
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

This is my first challenge in JavaScript and there is sill a lot of room for improvement. This is not the best solution but this is how I approach and solve the problem in my own way base of the current knowledge that I have. I am open to any suggestion or feedback. Thanks. (I changed the JS code to a much simpler one.)

Community feedback

  • Sönke Martens•120
    @RibosomPosted almost 3 years ago

    I like the solution. However, I think it would be better, if the validation errors are updated when the user fixes the problems and not when he submits again.

    Adding "input" event-listener could help you refresh the classes when the user changes the content.

    You also could check my response to another submission, where I outlined my approach, maybe there are some ideas you like.

    Marked as helpful
    1
  • Jaycee Altamia•330
    @simplyJCPosted almost 3 years ago

    Thank you for the feedback. Yes input listener is missing on this one. My first code has event listener to it but it was way too long because I didn't use the for each loop. I just found this other solution and refer to it. Will definitely check the link you provided and I will try to apply event listener for input.😊

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord