Skip to content
Submitted over 2 years ago

Intro component with sign up form solution

Brendan•1,120
@OneManBanned
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Intro component with sign-up form
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I would appreciate if someone could look over my JavaScript code.

It's the first time I've done a project involving more than a few lines of JavaScript. I'd like to know if I could have written the logic for Inputs as a group rather then as individual Inputs.

Community feedback

  • Facundo•100
    @FacualemandiPosted over 2 years ago

    The page is fine, no matter how you have written the code, while it works it is perfect, with practice you will improve your code.

    -I recommend that you add the event to the entire Document, and from there fire the events, thus avoiding having many 'addEventListener', if you look closely, you have 10 'addEventListener', and my code only has 1 'addEventListener' and my code is considerably shorter, you can check my profile.

    More than that, it's pretty good, good luck 👍

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord