Submitted over 1 year ago
Intro component with sign up form solution
@jordanheve
Design comparison
SolutionDesign
Solution retrospective
I would appreciate any suggestions to improve my code
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
LABELS π:
input
elements are having alabel
withsr-only
class, but we don't want to add individuallabel
for everyinput
element, Actually there's an native attribute namedaria-label
- A
aria-label
is used to create a caption for a form control. Thearia-label
can be associated with a form control either implicitly by placing the control element inside the label element, or explicitly by using the for attribute
- Effective form
labels
are required to make forms accessible. The purpose ofform
elements such ascheckboxes
,radio
buttons,input
fields, etc, is often apparent to sighted users
- Even if the
form
element is not programmatically labeled. Screen readers users require useful formlabels
to identifyform
fields, So here usingaria-label="{values}"
attributes forinput
is enough to be accessible
- Example:
<input type="text" aria-label="First Name" placeholder="First Name" id="first-name" name="first-name" class="registration-form__input">
- Now you can remove those
label
elements withsr-only
classes, usingaria-label
makes the code clean also
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
1@jordanhevePosted over 1 year agothanks this was very helpful to improve my code @0xAbdulKhalid
0@0xabdulkhaliqPosted over 1 year ago@jordanheve Glad you found it helpful ! π€
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord