Intro Component With Sign Up Form | Responsive | HTML CSS JS

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Jarrian, Congratulations on completing this challenge!

  Here’s some tips to improve your solution code:

  1.I saw that for some properties you’ve used rem and for others px. In this case it is better to use only one kind of unit to have a better organization for your code. relative units as rem or em that have a better fit if you want your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well.

  2.To reduce your css file and improve the performance loading your page you can use a tool called css minify that reduces the css code removing the unnecessary characters. You can use a VSCode plugin called minify css or this website tool to reduce your code: https://www.toptal.com/developers/cssminifier

  3.To save your time you can code you whole page using px and then in the end use a VsCode plugin called px to rem heres the link → https://marketplace.visualstudio.com/items?itemName=sainoba.px-to-rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Jarrian•150

  @godkingjayPosted about 2 years ago

  @correlucas thanks for the tips, I will definitely use these tools you mentioned.

  0
• 

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  Hi @godkingjay,

  Nice job on completing the challenge

  To center the content you can replace your rule with the following.

  .wrapper {
      display: flex;
      width: 100%;
      flex-direction: column;
      position: relative;
      align-items: center;
      justify-content: center;
      max-width: 1440px;
      margin-inline: auto;
      padding-inline: 2rem;
      padding-block: 0;
      min-height: 100vh;
  }
  

  it's just setting a min-height instead of height and remove the padding.

  Marked as helpful

  1