Intro component with sign up form - HTML, CSS & JS

Community feedback

• 

  Maksym Novikov•60

  @MoranGuyPosted over 3 years ago

  Hello Nicol,

  Congrats on your completed project, very well done! Just a small comment - I think it would be better if your button had cursor: pointer and also :active and :hover states.

  0

  ---

  

  Nicol•90

  @nmckennaPosted over 3 years ago

  Hi there,

  Yeah, you're right - handling those states would definitely be an improvement. I've tweaked the code a little to handle those states now.

  Thanks!

  0
• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Great work, also maybe lowering your min-width media breakpoint so that user like me would be able to see it even though we have lower dimension on that. Only that and I like your commenting on the js ^^

  0

  ---

  

  Nicol•90

  @nmckennaPosted over 3 years ago

  Hi there,

  You've got a great point there and I've lowered the min-width breakpoint and set it to what I hope is a more reasonable value.

  Thanks again for the feedback!

  0

  

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  @nmckenna Awesome seen it now ^^

  0
• 

  Rayane•1,935

  @RayaneBengaouiPosted over 3 years ago

  Hello Nicol,

  First of all, congrats for the challenge !

  I would just suggest to add max-width to your content so that when the screen is resized, the form doesn't fill the entire horizontal axis. This is my personnal preference, but I think it's easier to process the content of the page.

  Overall, well done for the challenge and happy coding ! 😃

  0

  ---

  

  Nicol•90

  @nmckennaPosted over 3 years ago

  Hi Enayar,

  Thanks for the feedback and your suggestion.

  I agree with you, I do think setting the max-width here is a definite improvement and I've updated the code with that change.

  Thanks!

  0