Intro component with sign up form

Community feedback

• 

  Fazza Razaq Amiarso•2,340

  @fazzaamiarsoPosted over 1 year ago

  Hi @Leone-Ricardo! Nice solution and great addition!

  I have some suggestion for you

  • For Submit Button, it's better to use a <button> as it can have image, icons, elements, and text as a display value, whreas <input> can only have text as value. So it become

  // <button> by default have "submit" type
   <button id="formSubmit" class="btn_submit">Claim your free trial</button>
  

  • If you implemented the suggestion above, then you can also refactor the inputs looping like this.

  // select all input elements
   const inputElements = document.querySelectorAll("input");
  
  // loop all input with forEach, where `inputEl` is the actual input element
    inputElements.forEach((inputEl, idx) => {
      inputEl.classList.remove("error");
      formError[idx].style.display = "none";
  
  //... other codes
    })
  

  I hope it helps! Cheers!

  1

  ---

  

  Leone DaVinci•340

  @Leone-RicardoPosted over 1 year ago

  Thanks for the feedback man! I wrote down your tip and I`ll try as soon as possible! Cheers! @fazzaamiarso

  0