Community feedback

• 

  P

  Rahexx•920

  @RahexxPosted about 2 months ago

  Great job with this challenge!

  There are some differences, but overall, good job.

  HTML

  Your HTML looks fine, but when using a class like error__message without having a block error, you should name it just error.
  I also recommend reading about ESLint—it will help you format your code properly, as there are some formatting issues in your HTML file.

  CSS

  Your styles look great, but I have one thing to point out. When naming variables, start with lowercase letters. Uppercase should be reserved for class names.
  In the future, mixing these conventions might cause misinterpretations, especially in JavaScript.

  JS

  Your JavaScript looks good; however, you didn’t add a mechanism to remove the error class. Because of this, the error never disappears.

  Overall

  Good job! 🚀

  Marked as helpful

  0

  ---

  

  chukwuma jennifer•160

  @jhenniiferPosted about 2 months ago

  @Rahexx Hi, thank you for taking the time to review my code. I will read about ESLint.

  Your comment on my CSS, I do not understand. Can you explain more?

  0

  

  P

  Rahexx•920

  @RahexxPosted about 2 months ago

  @jhenniifer Yeah, sure! So you named your variables like this:

  $Red: hsl(0, 100%, 74%);
  $Green: hsl(154, 59%, 51%);
  $Blue: hsl(248, 32%, 49%);
  $Dark-Blue: hsl(249, 10%, 26%); 
  $Grayish-Blue: hsl(246, 25%, 77%);
  

  You started naming them with uppercase, which is mainly reserved for classes in programming languages. At some point, you’ll encounter classes in JavaScript, especially in OOP (Object-Oriented Programming).

  In SASS, it's recommended to name your variables like this:

  $red: hsl(0, 100%, 74%);
  $green: hsl(154, 59%, 51%);
  $blue: hsl(248, 32%, 49%);
  $dark-nlue: hsl(249, 10%, 26%); 
  $grayish-blue: hsl(246, 25%, 77%);
  

  Or like this:

  $red: hsl(0, 100%, 74%);
  $green: hsl(154, 59%, 51%);
  $blue: hsl(248, 32%, 49%);
  $darkBlue: hsl(249, 10%, 26%); 
  $grayishBlue: hsl(246, 25%, 77%);
  

  Marked as helpful

  0

  

  chukwuma jennifer•160

  @jhenniiferPosted about 2 months ago

  @Rahexx Ooh, I get it now. My bad, I just copied it as it was written in the style guide.

  Off-topic, I never got you contact. Just wanted to remind of that.

  Thank you

  0

  

  chukwuma jennifer•160

  @jhenniiferPosted about 2 months ago

  @Rahexx Ooh, I get it now. My bad, I just copied it as it was written in the style guide.

  Off-topic, I never got you contact. Just wanted to remind of that.

  Thank you

  0