Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Intro component with Sign Up form

P

@muthucodes

Desktop design screenshot for the Intro component with sign-up form coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


  1. Please check if my logic for validating the form using JavaScript is correct.
  2. And please let me know if you are aware of a more simpler and standardized way to validate forms.

Community feedback

@0xabdulkhaliq

Posted

Vanakko Thala 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

  • Your solution generates accessibility error reports due to non-semantic markup
  • So fix it by replacing the <section class="intro-and-form"> with semantic element <main> to improve accessibility and organization of your page.

JavaScript 🏷️:

  • The way you declared variables are need to well structured

  • Take a look at the following example code which describes an efficient way of declaring variables

const firstName = "Your";
const lastName = "Name";
const emailAddress = "[email protected]";
const password = "supersecret";
  • instead try this,
const firstName =  "Your",
       lastName =  "Name",
       emailAddress = "[email protected]",
       •••
  • This single line declaration with separated commas will helps you to have a better structured code and improves readability though

I hope you find it useful! 😄 Above all, the solution you submitted is great!

Happy coding!

Marked as helpful

0

P

@muthucodes

Posted

@0xAbdulKhalid Thank you

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord