intro component w/ sign up form challenge - HTML, SASS, JS

Community feedback

• 

  Mojtaba Mosavi•3,760

  @MojtabaMosaviPosted almost 3 years ago

  1- The media query should be defined way earlier, personaly I switch to dektop view on around 43em but this depends on the content of the UI but in this case there is to much free space on the page when viewed on laptop screen, a litle bit of free space can help with readability but to much of it is no pleasing.

  2- Regarding box-shadows the one on promobox needs a bit of work, I could find the exact color but it should be something like: box-shadow: 0 9px 5px 1px #3e3c49; It should be link because its expected to function as one when clicked.

  3- You don't need to write recode the default behavior, for instance align-items:stretch is the default, no need to for writing it.

  4- Css properties allow you define global variables in you stylesheet which is much better practice rather than hardcoding the values every time and on projects of bigger scope this going to help alot with maintainability.

  Keep coding :=)

  0