Design comparison
Solution retrospective
Feedback is appreciated :)
Community feedback
- @palgrammingPosted over 3 years ago
Well looks like you have the majority of the desktop layout figured out but you have no mobile view currently. It is good to code these challenges multiple times so you could start this one over from scratch and do it mobile first or attempt to make this one mobile also
0@yunus-ujjainiPosted over 3 years ago@palgramming Hi, Last time as well my solution was not working in mobile for you. I have used media queries and on my mobile, this solution looks pretty decent; Even on my tablet, this solution is not breaking.
Can you tell me how exactly are you checking this mobile responsiveness? And which browser are you using for the same? That would be helpful
0@palgrammingPosted over 3 years ago@yunus-ujjaini firefox I think the issue is you are using "max-device-width" in your media query and not just "max-width" thus your site will not become mobile layout when one shrinks their desktop browser window
1@yunus-ujjainiPosted over 3 years ago@palgramming Exactly! I am using max-device-width.
I will check max-width out in the next submission.
And now finally able to reproduce the issue which you were mentioning in one of my previous submission. Thanks a lot.
Max-width won't break websites on mobile devices, right? Because all websites which I have created till now I have used max-device-width. And all are running fine on mobiles and tablets, Probably will check this out as well, else will have to write a media query for both max-device-width and max-width if that is the correct way to do this. Please suggest. :)
1@palgrammingPosted over 3 years ago@yunus-ujjaini it should not https://www.w3schools.com/cssref/css3_pr_mediaquery.asp
also I find it easier I think to do the CSS for mobile size and then use min-width as you transition up in width cause you are adding to the layout not having to remove as many settings normally as one does when transitioning from desktop to mobile
1@yunus-ujjainiPosted over 3 years ago@palgramming Ohh okay, I think yes that makes sense. Thanks for helping me out and for your suggestions. Going to implement the same in next submission. :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord