Design comparison
Solution retrospective
That project was very nice project, I build it with tailwindcss and vanella js for the function so i need your feedback to fixe my bugs or i don't now 🤷♀️🤷♀️🤷♂️🤷♂️ to manage my code So welcom your feedback
Community feedback
- @cacostedPosted about 2 years ago
Hi @aminetakdenti congrats on your solution, looks great.
Testing the form I noticed that, when you send it with errors and then you solve the errors there is no visual feedback, the error state remains, would be a good improvement to remove the error state when the form is OK.
I saw your
javaScript
and It looks very clean and compact. Something that I would recommend is to turnquerySelector('div > input')
intoquerySelector('input')
is simpler and it does the same thing.Also, I think you should try using the
FormData
object this is very handy when working with form and different inputs.⭐️ Here is a cool trick you can do with this:
const form = document.querySelector('form') // 👇Here you get an object where the keys are the input name, and the value is the input's value. const formData = Object.fromEntries(new FormData(form))
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord