Intro component solution. Mobile-first, JS, Flex, fun submit message!

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hello there, Eric Salvi! 👋

  Just wanted to say—that's a wicked awesome success message! 😆 Nice job on this challenge! 👏 The form validation works pretty well and the extra touch you added is pretty cool! 😀

  I haven't done much form validation from scratch before, but I've often seen code that stores the error messages for a form in an object and then only displays them if there is an error message in the object that corresponds to an input element. It keeps all the error messages in one place and might help you optimize your code a bit. Just a tip! 😉

  Keep coding (and happy coding, too)! 😁

  2

  ---

  

  Eric Salvi•1,330

  @ericsalviPosted over 3 years ago

  @ApplePieGiraffe I see what you did there! 😀

  Thank you so much for the tip and I'll have to check it out. Do you typically use a validation library for your forms or just never really had the opportunity to do validation from scratch?

  I do like the object idea and will keep this on the front of my mind with the next challenge that has a multiple input form with needed validation.

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  @ericsalvi

  Sure thing! 👍 I usually use a validation library for forms (which is why I haven't really done it from scratch yet), but I hope to give it a shot sometime soon! 😅

  1
• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 3 years ago

  Very nice work on this challenge, Eric! Nice to see you adding the extra detail with the confirmation message when you submit the form! 🙌

  To help screen reader users if any form fields are invalid, I'd recommend adding aria-live="polite" attributes to your error message elements. This will ensure the content of those elements is read out if it is updated to include an error message.

  Keep up the great work!

  1

  ---

  

  Eric Salvi•1,330

  @ericsalviPosted over 3 years ago

  @mattstuddert great suggestion.

  0

  

  Eric Salvi•1,330

  @ericsalviPosted over 3 years ago

  @mattstuddert I just remembered to implement this suggestion. Just did. Do you mind checking it out to make sure this is what you had suggested?

  0
• 

  Renzo•175

  @renzo4webPosted over 3 years ago

  Very good solution congratulations, well done adding a feedback when the form has been sent.

  1

  ---

  

  Eric Salvi•1,330

  @ericsalviPosted over 3 years ago

  @w3renzo thank you.

  0