Design comparison
SolutionDesign
Solution retrospective
My second project on react. Would love some feedback.
Community feedback
- @Andro87Posted almost 2 years ago
Hi oc-garcia! Great job in completing this challenge!
To improve your solution you can:
-use box-sizing: border-box property for all elements to include the padding and border in an element's total width and height:
*{ box-sizing:border-box }
-add max-width and margin: auto-properties in the "page-container" class (es. max-width: 90% for small devices, max-width: 58rem for bigger ones) to view the optimal layout based on the device's screen size.
Happy coding!!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord