intro component and sign up form using html, css nd javascript

Community feedback

• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  hay! Samuel Nice work

  Marked as helpful

  0

  ---

  

  Ogunniyi Samuel•430

  @StarisblackPosted almost 3 years ago

  @Crazimonk thanks

  1
• 

  Lorenzo Franco•480

  @LfrancosPosted almost 3 years ago

  Hi Samuel! This is looking really nice, Congratulations!

  There are 2 things that are calling my attention in my perspective, but what you have is looking really nice.

  • It would be nice that if you have errors it shows you all at once. Right now if I'm missing the name it tells me but is not showing any error in the other inputs. So I fix that one error and then I get another error. I feel that could be a little annoying for the user.

  To fix that I would remove the return form the functions since every time the code finds a return it exits that function. You could add a variable that has the value "true" or "false" instead.

  • Would be nice if in the email input when it is empty it says "Email can not be empty" instead of "Looks like this is not an email".

  • And the last thing is that when you look at the code in 4k monitors the margin is to small and makes the design look a little to stretched, I would add a max-width to the main component making sure it will have an easy read for all the screens. Surfing the web I've seen that they recommend that the maximum width is 1440. But I encourage you to research and make the decision based on what you feel is right!

  Hope this helps : )

  1

  ---

  

  Ogunniyi Samuel•430

  @StarisblackPosted almost 3 years ago

  @Lfrancos i will work on that. thanks bro

  0