Intro and Dropdown

Hi Kian, well done here in putting this together, which isn't easy to do, given how many parts there are in this challenge! Anyway, about the dropdowns, what I did when I worked on this challenge is that I used Heydon Pickering's post on menus and menu buttons as a blueprint since I wanted to try to make my dropdown menus as accessible as possible. I don't think I did a super job as it's still missing a few things (like data-visible), but it's functional, so if you're interested you can check out the draft I put together on CodePen here: https://codepen.io/elaineleung/pen/poLpzge

One thing I wanted to point out in your solution is that, where you have nav right now, I actually would use the header landmark instead; the nav should strictly just contain the navigation links and not the site logo.

I hope some of this can help you out, and once again, great work! 🙂

Hey @kiangopez,

nice job on this challenge. I also assume you do not have access to the figma file, which gives it even more merit!

Regarding the dropdowns, they are working fine, I would only make some adjustments:

• Add an eventlistener for the window when it resizes and remove the dropdown classes when activated. This will ensure that the dropdown doesn't stay open, when changing screen sizes (for example turning the phone to landscape mode).

• In the eventlisteners for each dropdown, also toggle the classes to be able to close one dropdown, when another one opens.

My approach is far from perfect, but you can check my code here to get an idea of what I mean.

Hope this helps!

Happy coding and happy weekend :)

Patrick