Design comparison
Solution retrospective
Interractive rating component project
Community feedback
- @visualdennissPosted over 1 year ago
Hey there, you solution looks great and also JS seems to be working without any issues. Good work! It seems like you have used px values overall for font-sizes, margins etc. So I'd have a small suggestion regarding accessibility:
Try to avoid using px as much as you can, instead try to use em or rem to improve accessibility. Here is a great resource on YT for that: https://www.youtube.com/watch?v=dHbYcAncAgQ
Hope you find this feedback helpful!
Marked as helpful1@riteshkumarldhPosted over 1 year ago@visualdenniss Hi, Thanks for your suggestion. i will consider in next challenge.
0 - @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML π·οΈ:
- This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to
non-semantic
markup, which lack landmark for a webpage
- So fix it by replacing the
<div class="wrapper">
element with the semantic element<main>
in yourindex.html
file to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>
or<span>
- They convey the structure of your page. For example, the
<main>
element should include all content directly related to the page's main idea, so there should only be one per page
HEADINGS β οΈ:
- And, this solution had also generated accessibility error report due to lack of level-one heading
<h1>
- Every site must want at least one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a
sr-only
class to hide it from visual users (it will be useful for visually impaired users)
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0@riteshkumarldhPosted over 1 year ago@0xAbdulKhalid Hi, Thanks for your valuable points will consider in next challenge
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord