Interative rating component with html and css

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component.

  body {
      min-height: 100vh;
      display: grid;
      place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .container {
    justify-content: center;
    align-items: center;
    margin: auto;
    margin-top: 12%;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Uwakmfon Ekong•90

  @Uwakmfon-EkongPosted over 1 year ago

  Thank you so much @0xAbdulKhalid

  0
• 

  Luka Glonti•3,440

  @lack21Posted over 1 year ago

  Great job 👍, but I have a recommendation!

  • You used margin: auto and margin-top: 12% on the .container to center the layout, it's good but there's a better way, remove those two styles and add these styles to the body

  {
    display: grid;
    place-content: center;
    min-height: 100vh;
  }
  

  Like this .container will be centered!

  Marked as helpful

  0

  ---

  

  Uwakmfon Ekong•90

  @Uwakmfon-EkongPosted over 1 year ago

  thank you so much @lack21

  0