Design comparison
Solution retrospective
Getting into Java script,any suggestion to improve is accepted
Community feedback
- Account deleted
Hello @Codie123 , I really like how you work over the syles and specially the card animation on the thank-you modal : )
I saw your solution I would like to notice the following. If the user does not click a rate button the user can still submitting and the second modal appears anyway. It is on purpose ? I think this could be solved simply testing for an empty selection before submitting... I would like to see the code but it appears the link that points to your repo redirect to GitHub 404 Not found. Maybe the repo is on private mode ?
Best wishes and see you around : )
0@Codie123Posted over 2 years ago@alexcumplido Thank you for you reply i have changed the repo visibility to public
0Account deletedHello @Codie123 , I do really like the design and how you applied the gradient to the modals. Just I would like to notice that If the user does not click any rate button and click on the submit button the thank-you modal shows itself anyway.
This can be fixed by testing for an empty rating inside your
submitBtn.addEventListener
before submitting or disabling the submit button at first an enabling it after the user clicks any rate button.Hope this helps, happy conding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord