Design comparison
Solution retrospective
Some colors into the style-guide doesn't match with the design photo, there are things that i don't know or it work like this?
Community feedback
- @3eze3Posted 9 months ago
Hey!๐ , very good solution for this challenge Luigi. ๐
I have some recommendations that may help you in future challenges.๐งจ
HTML:
- The use of semantic tags, such as a <form> and <inputs> for user interaction.
- You can also remove the alt in decoration images like these:
<img src="icon-star.svg" alt aria-hidden=true>
- The use of the <h1> is exclusively one, you can take reference to the hierarchy of titles, I leave here a resource on this topic Hierarchy of titles
CSS:
-
As for the colors, you can really change them, or put your characteristic touch in the projects, as long as they are related to the page.
-
Also you have some problems when it comes to height and aesthetics with the buttons, you can try giving a "border-radius:50%" and "height:4rem" and play with this, so that it does not break and looks proporcinal.
-
Also the common styles can be grouped in classes, to avoid duplication of styles.
I hope these comments help you for your next challenges, keep it up, being constant is the key ๐ฅ.
Happy coding ๐
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord