interactive-rating-component-main

Community feedback

• 

  Eileen dangelo•1,600

  @EileenpkPosted over 1 year ago

  Hi Matthew!

  Your project looks great, it seems like you put a lot of hard work into it.

  I thought this might be a helpful tip.

  Consider your naming conventions. If you had never seen this code before would you know right away without looking at the HTML what p (in the JavaScript) was? It takes time to think of very descriptive names for things, but it's worth trying to write code with the knowledge that out in the wild ( and in a professional setting) more time will be spent reading, and editing it than the initial writing of the code. Anything we can do to make it easier for the next dev on the project should be done.

  For example, I would change let p = document.querySelector(".numrate"); to

  let selectedRating = document.querySelector(".numrate");

  Other than that your code is awesome, keep up the good work!!

  Hope you found this helpful!

  • Let's connect on LinkedIn! - @Eileenpk

  Marked as helpful

  1

  ---

  

  Matthew•400

  @matthew-marcoPosted over 1 year ago

  @Eileenpk

  thank you so much for your comment I will consider that in my next project

  0