Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Interactive-rating-component

@Legendsusama

Desktop design screenshot for the Interactive rating component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@AGutierrezR

Posted

Hello there 👋. Good job on completing the challenge!

I have some suggestions about your code that might interest you.

General Structure and HTML:

  • Wrap the primary content within the <main> tag instead of using it as a standalone component like a <div>.
  • All the content should be contained within landmarks. Every page minimally needs a <main> element.
  • Use a <form> and <input type="radio"> instead of using <div>.

CSS and Styling:

  • Implement CSS custom properties to define and utilize project colors more easily.
  • Avoid using px for font-size (like you did in the title), you could read this article to learn why. Letter spacing and line height must not be in px, use rem for all the font-related properties.
  • Instead of fixed widths, employ max-width and min-width for flexible and responsive design.

Accessibility and Semantic HTML:

  • The illustration images are decorative, so their alt text must be emptyalt="".
  • Use a <form> and <input type="radio"> instead of using <div>, this is better for screen reader users.
  • Maintain semantic HTML structure by using appropriate elements for their intended purposes.
  • Ensure compliance with accessibility standards by avoiding redundant or unnecessary tags and utilizing appropriate landmark elements.

I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!

Happy coding!

Marked as helpful

0

@Legendsusama

Posted

@AGutierrezR

I wanted to express my sincere gratitude for your invaluable feedback on my code. Your suggestions were incredibly beneficial, and I truly appreciate the time and effort you put into helping me improve. Your support means a lot to me, and I'm eager to continue learning and refining my skills. 🚀

I hope that you'll continue to share your insights and correct me in future posts as well. Your guidance is instrumental in my growth, and I value our collaborative efforts. 🌱

Thank you once again for your assistance. Looking forward to more fruitful exchanges! 🙏

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord