Design comparison
Solution retrospective
Hi All,
Any suggest or feedback is more than appreciated. Try to become a front-end developer this year, need all of your suggestion! THANKS!!!
Community feedback
- @Kamasah-DicksonPosted over 2 years ago
Your solution looks great but this are a few things I want you to know and fix.
-
There should be a semantic tag eg. <main> <aside> <footer> in your solutions. In this challenge you can use the main. Change the parent div of the card into main or wrap your card in a main tag to fix the accessibility issues.
-
Also reduce the cards background opacity to match the designs BG colour.
-
There is not enough padding in your card also.
Besides good luck, have a great day and a happy coding👍💻
1@SuprefunerPosted over 2 years ago@Kamasah-Dickson Hi, Thanks for your feedback. Always forget to use senmatic tag. I'll keep that in mind and use them in my coming project.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord