Interactive-rating-component

Community feedback

• 

  Fazza Razaq Amiarso•2,340

  @fazzaamiarsoPosted over 2 years ago

  Hello Kadheryna! Nice work!

  I have some tips for you.

  • On accessibility you can wrap both section in main elements. This ensures all of your contents are inside a landmark.
  • In submitValue, you can do a guard clause to make it cleaner. Guard clause means if the condition is not valid, don't do anything.
  • To do string concatenation, you can use template literal which is easier to write. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals

  Here is the implementations.

  const submitValue = () => {
  	if (btnValue === undefined) return; // guard clause with early return;
  	firstBox.style.display = "none";
  	secondBox.style.display = "flex";
          result.innerHTML = `You selected ${btnValue} out of 5`; //template literals
  };
  

  I hope it helps! Cheers!

  Marked as helpful

  1