Skip to content
Submitted 8 months ago

Interactive-rating-component

Mahbub Hossen•20
@mhbabu2002
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Interactive rating component
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I am most proud of doing the project.

What challenges did you encounter, and how did you overcome them?

I face a problem with Flexbox in CSS while doing the project. Then learn Flexbox through YouTube and complete the project.

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted 8 months ago

    Salaam Alaikum 👋. Congratulations on successfully completing the challenge! 🎉

    • I have a suggestion regarding your code that I believe will be of great interest to you.

    HTML 🏷️:

    • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.
    • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers
    • For example:
      • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
      • The <footer> typically contains information about the author of the section, copyright data or links to related documents.
    • So resolve the issue by wrapping the both component states (.rate-container & .thank-you) using the proper semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page
    • So the resulted markup would be like this,
    <body>
  <main>
     <!-- Rating state start -->
       <div class="rate-container"></div>
     <!-- Rating state end -->

     <!-- Thank you state start -->
        <div class="thank-you"></div>
     <!-- Thank you state end -->
  </main>

  <footer class="attribution"></footer>
</body>

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    1
    Mahbub Hossen•20
    @mhbabu2002Posted 8 months ago

    Thank you very much for your valuable comments. @0xabdulkhalid

    0
    Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted 8 months ago

    @mhbabu2002 Glad you found it helpful ! 🤠

    1
  • Shukhrat Turdiev•90
    @shukhratgithubPosted 8 months ago

    I don't realy like the way you did that. There has been a small difference in size from actual one. I really apreciate if you take a look one more time!

    1
    Mahbub Hossen•20
    @mhbabu2002Posted 8 months ago

    @shukhratgithub Thanks for your valuable feedback.

    0
  • Husniddin Ayubjonov•1,110
    @HusniddinAyubjonovPosted 8 months ago

    Hey 👋 You create good ✨️ Congratulations 🎊 👏

    1
    Mahbub Hossen•20
    @mhbabu2002Posted 8 months ago

    @HusniddinAyubjonov Thank You very much

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord