Design comparison
SolutionDesign
Solution retrospective
I'm not sure if I'm doing the centering part of the products to the screen correctly.
Community feedback
- @elaineleungPosted about 2 years ago
Hi Owsla, I think this was a good attempt, well done here! About the centering, I see that you're using margins for the individual parts into the card. The best way to position things is to firstly use padding on the card itself; I'd probably put
padding: 2rem
for thebox
in desktop view; that way, you won't need addmargin-left
ormargin-right
for the items inside.Some other feedback I have:
- Your icon is missing, so you might want to check the path!
- I suggest writing an if/else statement to handle what happens when the user clicks submit without clicking on a score.
- I see that you got a fixed width set on the
box
; try usingmax-width
instead so that it can be more responsive.
Hope this helps a bit, and good luck!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord