Design comparison
Solution retrospective
First time doing java-script, This challange took multiple hours to complete it and if theres any issues or complement please let me know,Thank you.
Community feedback
- @Anubhav-RayPosted over 1 year ago
Hi @wajeeNPC
Congrats on completing your first JavaScript project.
I have some suggestions you might consider to improve your code.
-
To make your webpage accessible you should use atleast one main tag to cover your entire html and use forward slash to specify path for image and try to use semantic html.
-
Use alt tag for images that have some special meaning so that it might be helpful for screen readers.
-
Your rating is being submitted even if user has not selected any rating.Try to disable the submit button until user has selected the option.Its giving selected 0 out of 5.
-
Multiple ratings are being selected (or their color state is being changed) if one tries to click on every rating so try to fix it.
-
In submit button you have used spaces in html itself to make spacing between the letters of word submit.Try to use CSS letter-spacing property.
-
You should also write a detailed Readme so that others can gain additional insight on your project.
Above all, The project is Well Done.I hope these tips will help you.
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord