Design comparison
Community feedback
- @correlucasPosted about 2 years ago
👾Hello Dipendu Sur, congratulations for your new solution!
Here’s some tips to improve your solution code:
1.Replace the
div
with<main>
(every page should have a main landmark and also a main h1 heading)2.Add a margin of around
margin: 20px
to avoid the card touching the screen edges while it scales down.3.
<img src="./images/icon-star.svg" alt="">
Don't forget to use thealt
text to allow screen readers to recognize that img. Adding alternative text to photos is first and foremost a principle of web accessibility. Visually impaired users using screen readers will be read an alt attribute to better understand an on-page image.✌️ I hope this helps you and happy coding!
Marked as helpful0@correlucasPosted about 2 years ago@Dipendu7718 for its fine that I see what you can improve in your others solution or it bother you? Just to know if I can continue.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord