interactive-rating-component

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage

  ---

  • So fix it by replacing the <div class="container"> element with the semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  HEADINGS ⚠️:

  ---

  • And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  CSS 🎨:

  • let me explain, How you can easily center the component.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component

  body {
      min-height: 100vh;
      display: grid;
      place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .box {
    margin: auto;
    margin-top: 200px;
  }
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Ahmed Iyanuoluwa•130

  @iyanu752Posted over 1 year ago

  @0xAbdulKhalid Thank you very much for the suggestions, both the html and the css, I had a hard time figuring out why i got so many errors on my submission on the HTML, you explained it so easily, once again, thank you very much

  0
• 

  Elio Flores•400

  @eliofloPosted over 1 year ago

  Hi,

  Great job on your website so far! I have a few suggestions that could help improve your site even further:

  • Check your website's accessibility and HTML structure by using validation tools like the HTML Validator and Accessibility tool. Making necessary fixes based on these reports can improve your site's overall quality and accessibility.

  • Ensure that your site follows HTML semantic conventions by including appropriate tags, such as the h1 tag for your main heading, as well as using main and footer tags where necessary. You can read more about HTML semantics on resources like mdn and w3schools.

  • Consider using a radio button instead of a regular button for your rating system since the button behaves like a radio button. This can make the rating process more intuitive for users.

  Keep up the great work and let me know if you have any questions!

  Elio Flores

  Marked as helpful

  0

  ---

  

  Ahmed Iyanuoluwa•130

  @iyanu752Posted over 1 year ago

  @elioflo thank you very much for the feedback, I will take these suggestions into account moving faward

  0