Design comparison
Solution retrospective
this my first attend using some JS and DOM and any recommendation is welcome
Community feedback
- @icaroMendes777Posted about 2 years ago
a few tips:
1- the rating buttons and the submit are no aligned (in the design they both end together in the same vertical alignment)
2- this one is one mistake more that 50% of people have made in this challenge: the case where the user clicks submit without giving a rating. Gotta lock the submit function until the user gives a rating first.
3-I didn't look in deep, but your css looks a little bit bloated. like:
.thank-you-state img .img
can be just.thank-you-state .img
.thank-you-state .state-result p
can be just.state-result p
So, your page is very good, 😀 most of it is done correctly, and it looks very loyal to the original design. These are just tips for improving yous skills further. 90% is done already.
Marked as helpful0@ispirar2Posted about 2 years ago@icaroMendes777 Thanks for mentioning these things I make sure fix them and I will try to make it better next time
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord