Design comparison
Solution retrospective
Hello everyone, some tips to improve my code? Any feedbacks are appreciated
Community feedback
- @correlucasPosted about 2 years ago
👾Hello Jesús Yadiel, Congratulations on completing this challenge!
Some suggestions for you:
1.To reduce your css file and improve the performance loading your page you can use a tool called
css minify
that reduces the css code removing the unnecessary characters. You can use aVSCode
plugin calledminify css
or this website tool to reduce your code:https://www.toptal.com/developers/cssminifier
2.Use units as
rem
orem
instead ofpx
to improve your performance by resizing fonts between different screens and devices.To save your time you can code you whole page using
px
and then in the end use a VsCode plugin called px to rem heres the link → https://marketplace.visualstudio.com/items?itemName=sainoba.px-to-rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem✌️ I hope this helps you and happy coding!
Marked as helpful1 - @hyrongennikePosted about 2 years ago
Hi @yeezusch23,
Congrats on completing the challenge
Just a suggestion, instead of giving 0 when no rating is selected I would suggest just disabling the button until a rating is selected this can be done by adding the disabled attribute on the button and removing it when the rating is clicked.
Hope this is helpful.
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord