interactive-rating-component

Community feedback

• 

  Sahiru•220

  @bhatsahil13579Posted almost 2 years ago

  Nice job cryptososso 😀

  Here are some feedbacks

  Your all buttons are having borders you can remove them simply by adding ( border : none)

  In Js Part :

  i see that you have added event Listener for each button separately but you can do it by only adding event Listener one time through ForEach method like this :

  btn.forEach(elements => 
     
  elements.addEventListener("click", () => {
  }
    })
  

  but make sure you have selected that element by querySelectorAll

  and also there is no need for score1 , score2 like that you can simply do it like this :

  btn.forEach(elements => {``
     
  elements.addEventListener("click", () => {``
     
   rateScore.textContent = elements.textContent
  }
   })
  

  and i can click submit button without submitting rating to stop that add disabled attribute to your all rating buttons and then in js you can remove that attribute if the click is true like this

  btn.forEach(elements => {
     
  elements.addEventListener("click", (task) => {
       
  rateScore.textContent = elements.textContent
      
   if (task) {
      
  btn.removeAttribute("disabled"  )
        }
  
     })
  }
   }) 
  

  hope it will help you 😀😀

  Marked as helpful

  0

  ---

  

  cryptososso•150

  @cryptosossoPosted almost 2 years ago

  @bhatsahil13579 Thank you for the feedback very helpful

  0
• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The “icons/illustrations” in this component serve no other purpose than to be decorative; They add no value. There alt tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • The proper way to build the "rating buttons" in this challenge is to create a form and inside of it, there should be fiveinput radios and each input should have a label attached to it to make the buttons accessible. Finally wrap all the inputs and labels inside a fieldset to prevent users from making more than one selection.

  More Info:📚

  MDN <input type="radio">

  MDN <fieldset>: The Field Set element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  0

  ---

  

  cryptososso•150

  @cryptosossoPosted almost 2 years ago

  @vcarames Thank you very much for your feedback

  1