interactive-rating project

Community feedback

• 

  Ozzy-codes•130

  @Ozzy-codesPosted over 1 year ago

  Hi @llr3v0ll

  Congrats on completing this challenge!

  I wanted to bring to your attention that It appears the component doesn't quite fit in the 375px mobile view. Take a look at my forked repo for a quick suggestion!

  Also very interesting use of radio inputs to toggle classes, was that inspired from MDN? I wonder how this approach takes in the scope of accessibility, any experts that can weigh in? @visualdenniss

  Lastly, I did a little refactor of your JS, pulling out lines 12-14. I'm curious to hear what your objective was with utilizing the plm variable?

  best,

  Ozzy

  1
• 

  Adebukola Adeyinka Omowole•280

  @AdebukolPosted over 1 year ago

  well done, you can use the onclick function to style it js

  1
• 

  Franek Bury•60

  @franekbuPosted over 1 year ago

  good job, but your site is not responsive as it should, just use

  @media and screen (max-width:value) {
  body{
  change what you need
  }
  etc
  }
  

  0