Design comparison
Solution retrospective
This is an interactive rating component made with html, css, and javascript let me know what you think about this and if there is anyway to make improvement on this project. Thanks
Community feedback
- @HamzaouladevPosted over 1 year ago
hello @Hola-Code001, here's some feedback regarding your layout i hope you find interesting:
- it's usually a bad idea to give your component a fixed height, your component should dynamically handle any large amount of content in any screen width without running into overflowing issues, its best to leave the height to a default
auto
. - a cool, simple way to handle spacing without worrying about unpredicted flexbox behavior is called The lobotomized owl selector, i invite you to check it out!
i hope you found my feedback helpful, keep hacking!
Marked as helpful0 - it's usually a bad idea to give your component a fixed height, your component should dynamically handle any large amount of content in any screen width without running into overflowing issues, its best to leave the height to a default
- @LysitheaDarkKnightPosted over 1 year ago
Hello, how are you? Good job on completing the challenge!
To combine your wrapper
width
andmax-width
, just writemin(90%, 400px)
forwidth
! It'll automatically resize your element depending on the screen size by using whichever can be the smallest! It'll save you 2 lines of code so I recommend you try it out!Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord