Design comparison
SolutionDesign
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- To not only improve your HTML code but to identify the main content of you page, you will want to wrap your entire component inside the
main
element.
More Info:📚
- Your ratings should have an
active
state to let users know which rating they have chosen.
- The button styling needs to be updated to better match the FEM design.
- The proper way to build this challenge is to create a
form
and inside of it, the “rating buttons” should be built using aninput radio
(wrap all of them inside afieldset
), since this will prevent additional buttons from being active at the same time, and it should have alabel
element attached to it for accessibility.
More Info:📚
MDN <fieldset>: The Field Set element
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful1@Trojan2022Posted almost 2 years ago@vcarames Thanks a lot for your suggestions, they are very useful for me. I will learn this and will improve next projects.
0@VCaramesPosted almost 2 years ago@Trojan2022
I am glad that I was able to help out!
Keep it up!
1 - To not only improve your HTML code but to identify the main content of you page, you will want to wrap your entire component inside the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord